Accept nullable service_name on SP configuration push#606
Open
kayjoosten wants to merge 1 commit into
Open
Conversation
Gateway now expects an optional service_name in pushed SP configuration so it can display a friendly name during authentication. Middleware still rejected that key because the validator only allowed the older field set, and fresh CI installs had become flaky because phpcpd-shim was fetched from a dead upstream Git host. Allow service_name as an optional nullable field in the service provider validator and add regression coverage for valid and invalid configurations. Replace the dead phpcpd shim with the maintained phpcpd-next package so fresh installs keep working reliably. Resolves: #589
kayjoosten
force-pushed
the
feature/issue-589-service-name-config
branch
from
3ef68b6 to
49d2b19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateway needs a display name to show during authentication (Gateway #624 already reads a
service_namekey from the pushed SP config JSON blob). Middleware was rejecting any config push containing that key, since ServiceProviderConfigurationValidator whitelists the exact set of allowed keys per service provider entry.Add
service_nameas an optional, nullable string: omitted keys default to null before the key-set check runs, so existing config pushes that don't set it keep working unchanged.Refs #589